implement tasks #3622
implement tasks #3622
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve your pull request. The keyframes implementation needs to be adjusted to use from/to with the transform and rotate properties, as per the task requirements. Additionally, ensure the basic functionality works without the BEM modifier speed-up. Once these are resolved, your solution will be in great shape! Keep up the great work, and don't hesitate to reach out if you need any help. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| @@ -1,5 +1,9 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <html | |||
There was a problem hiding this comment.
The <html> tag should not be self-closing. It should be written as <html> without the trailing slash.
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets the task requirements and constraints effectively. The keyframes are correctly implemented, the stopwatch is centered and styled appropriately, and the BEM modifier speed-up is used correctly. The HTML structure and SCSS linking are also well-executed.
However, please ensure that the basic functionality of the stopwatch works without the BEM modifier speed-up, as per the task requirements. If this is already handled, then no changes are needed.
Keep up the good work, and remember to review the comments to further improve your code. Addressing these points will help you avoid similar issues in the future and enhance your learning experience. Keep pushing forward! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <h1>Stop watch</h1> | ||
| <!-- #endregion --> | ||
| <body class="body"> | ||
| <div class="stopwatch stopwatch--speed-up"> |
There was a problem hiding this comment.
Ensure that the basic functionality of the stopwatch works without the BEM modifier speed-up, as per the task requirements. If this is already handled in your styles or scripts, then no changes are needed here.
DEMO LINK
Keyframes implemented using from/to + transform with rotate property
Stopwatch is centered and has the correct arrows size
All
Typical Mistakesfrom theBEMlesson theory are checked.Code follows all the Code Style Rules ❗️