clock solution #3626
clock solution #3626
Conversation
reb0rned
commented
Feb 8, 2025
reb0rned
commented
- Keyframes implemented using from/to + transform with rotate property
- Stopwatch is centered and has the correct arrows size
- All Typical Mistakes from the BEM lesson theory are checked.
- Code follows all the Code Style Rules ❗️
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code is mostly on point, there are a few critical issues that need addressing before we can approve it. Specifically, the BEM modifier usage needs correction to ensure the speed-up functionality works as intended. Additionally, please verify your code against the BEM lesson's "Typical Mistakes" checklist and the Code Style Rules. Lastly, remove any unnecessary files like additionalPrompt to keep the project clean. Once these changes are made, you'll be all set! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Great job on your progress! 🎉 Your code meets most of the task requirements, but there are a few areas to improve. The critical issue lies in the BEM modifier usage; ensure stopwatch--speed-up is applied correctly in the HTML to achieve the desired functionality. Also, verify your code against the BEM checklist and Code Style Rules, and remove any unnecessary files like additionalPrompt. Address these issues to enhance your skills and avoid similar problems in the future. Keep up the good work and continue learning from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -17,6 +17,10 @@ | |||
| /> | |||
| </head> | |||
| <body> | |||
| <h1>Stop watch</h1> | |||
| <div class="stopwatch stopwatch--speed-up"> | |||
There was a problem hiding this comment.
The class stopwatch--speed-up is intended to be a BEM modifier. Ensure that it is used correctly according to BEM conventions. Typically, a BEM modifier should modify a block or element, and it should be used in conjunction with the block class, like stopwatch stopwatch--speed-up.
| .stopwatch--speed-up .stopwatch__min { | ||
| animation-duration: 600s; | ||
| } | ||
|
|
||
| .stopwatch--speed-up .stopwatch__sec { | ||
| animation-duration: 10s; | ||
| } |
There was a problem hiding this comment.
The styles for the stopwatch--speed-up modifier are correctly defined here. However, ensure that the HTML file applies this modifier correctly to the stopwatch block to achieve the intended speed-up effect.
