Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution 09.02.25 #3627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Alya-ya
Copy link

@Alya-ya Alya-ya commented Feb 9, 2025

  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the stopwatch! 🎉 The structure and styling are well done, and you've effectively used BEM and animations. There's a minor suggestion to ensure flexbox properties are placed after display: flex; for proper application, but overall, your code meets the task requirements. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +3 to +4
justify-content: center;
align-items: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justify-content and align-items properties should be placed after the display: flex; declaration to ensure they are applied correctly. Flexbox properties only take effect when the element is a flex container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants