-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task #1741
base: master
Are you sure you want to change the base?
task #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your code is almost there! 🎉 However, there are a couple of critical issues that need to be addressed before we can approve the PR. Specifically, the sell_product
method in the CinemaBar
class should accept both product
and customer
as parameters, and the parameter number
in the cinema_visit
function should be renamed to hall_number
to align with the task description. Once these changes are made, your solution will meet all the requirements. Keep up the great work, and feel free to reach out if you need any help! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
app/main.py
Outdated
) -> None: | ||
customer_objects = [ | ||
Customer(name=c["name"], food=c["food"]) | ||
for c in customers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c
bad variable name
No description provided.