Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task #1741

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

task #1741

wants to merge 8 commits into from

Conversation

Matsebon
Copy link

@Matsebon Matsebon commented Mar 1, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your code is almost there! 🎉 However, there are a couple of critical issues that need to be addressed before we can approve the PR. Specifically, the sell_product method in the CinemaBar class should accept both product and customer as parameters, and the parameter number in the cinema_visit function should be renamed to hall_number to align with the task description. Once these changes are made, your solution will meet all the requirements. Keep up the great work, and feel free to reach out if you need any help! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@Matsebon Matsebon closed this Mar 8, 2025
@Matsebon Matsebon reopened this Mar 8, 2025
@Matsebon Matsebon closed this Mar 8, 2025
@Matsebon Matsebon reopened this Mar 8, 2025
app/main.py Outdated
) -> None:
customer_objects = [
Customer(name=c["name"], food=c["food"])
for c in customers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c bad variable name

@Matsebon Matsebon closed this Mar 9, 2025
@Matsebon Matsebon reopened this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants