Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1750

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added app/cinema/__init__.py
Empty file.
7 changes: 7 additions & 0 deletions app/cinema/bar.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from app.people.customer import Customer


class CinemaBar:

def sell_product(self, product: str, customer: Customer):
print(f"Cinema bar sold {product} to {customer.name}")
13 changes: 13 additions & 0 deletions app/cinema/hall.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from app.people.customer import Customer
from app.people.cinema_staff import Cleaner


class CinemaHall:
def __init__(self, number: int):
self.number = number

def movie_session(self, movie_name: str, customers: Customer, cleaning_staff: Cleaner):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The customers parameter should be a list of Customer instances, not a single Customer instance. Update the parameter type to List[Customer] and iterate over this list to call watch_movie on each customer.

print(f"{movie_name} started in hall number {self.number}.")
Customer.watch_movie()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method watch_movie should be called on each Customer instance, not on the Customer class. Iterate over the customers list and call customer.watch_movie(movie_name) for each customer.

print(f"{movie_name} ended.")
Cleaner.clean_hall(self.number)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method clean_hall should be called on the cleaning_staff instance, not on the Cleaner class. Use cleaning_staff.clean_hall(self.number) instead.

14 changes: 11 additions & 3 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# write your imports here
from app.cinema.bar import CinemaBar
from app.cinema.hall import CinemaHall
from app.people.customer import Customer
from app.people.cinema_staff import Cleaner


def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str):
# write you code here
pass
result_list = []
for element in customers:
result_list.append(Customer(element["name"], element["food"]))
for customer in result_list:
CinemaBar.sell_product(customer.food, customer)
for element in result_list:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sell_product method should be called as a static method of CinemaBar, not as an instance method. Use CinemaBar().sell_product(customer.food, customer) instead.

CinemaHall.movie_session(movie, element.name, cleaner)
Empty file added app/people/__init__.py
Empty file.
6 changes: 6 additions & 0 deletions app/people/cinema_staff.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class Cleaner:
def __init__(self, name: str):
self.name = name

def clean_hall(self, hall_number: int):
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.")
7 changes: 7 additions & 0 deletions app/people/customer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Customer:
def __init__(self, name: str, food: str):
self.name = name
self.food = food

def watch_movie(self, movie: str):
print(f"{self.name} is watching {movie}")
Loading