Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added app/__init__.py
Empty file.
Empty file added app/cinema/__init__.py
Empty file.
9 changes: 9 additions & 0 deletions app/cinema/bar.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from __future__ import annotations
from typing import Any
from app.people.customer import Customer


class CinemaBar:
@staticmethod
def sell_product(customer: Customer, product: str) -> Any:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sell_product method should not have a return type hint -> Any. According to the task requirements, this method should only print a message and not return any value. Please remove the return type hint.

print(f"Cinema bar sold {product} to {customer.name}.")
18 changes: 18 additions & 0 deletions app/cinema/hall.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from __future__ import annotations
from app.people.cinema_staff import Cleaner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement from app.people.cinema_staff import Cleaner is unnecessary and can be removed. The task requirements do not specify the need for this import.



class CinemaHall:
def __init__(self, number: int) -> None:
self.number = number

def movie_session(self, movie_name: str, customers: list,
cleaning_staff: Cleaner) -> None:
print(f'"{movie_name}" started in hall number {self.number}.')

for customer in customers:
customer.watch_movie(movie=movie_name)

print(f'"{movie_name}" ended.')

cleaning_staff.clean_hall(self.number)
19 changes: 15 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
# write your imports here
from typing import Any
from app.people.cinema_staff import Cleaner
from app.people.customer import Customer
from app.cinema.hall import CinemaHall
from app.cinema.bar import CinemaBar


def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str):
# write you code here
pass
def cinema_visit(customers: list, hall_number: int,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The customers parameter should have a more specific type hint indicating it is a list of dictionaries. Consider using list[dict] or list[dict[str, Any]] for clarity.

cleaner: str, movie: str) -> Any:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type hint -> Any is unnecessary because the function does not return any value. You can remove this type hint.

list_of_customers = [
Customer(dic["name"], dic["food"]) for dic in customers
]
hall = CinemaHall(hall_number)
cleaner_ = Cleaner(cleaner)
for custom in list_of_customers:
CinemaBar.sell_product(custom, custom.food)
hall.movie_session(movie, list_of_customers, cleaner_)
Empty file added app/people/__init__.py
Empty file.
6 changes: 6 additions & 0 deletions app/people/cinema_staff.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class Cleaner:
def __init__(self, name: str) -> None:
self.name = name

def clean_hall(self, hall_number: int) -> None:
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.")
7 changes: 7 additions & 0 deletions app/people/customer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Customer:
def __init__(self, name: str, food: str) -> None:
self.name = name
self.food = food

def watch_movie(self, movie: str) -> None:
print(f'{self.name} is watching "{movie}".')