RDA: Don't apply stored monitor configuration if session is remote. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raveit65
reviewed
Aug 20, 2020
| @@ -2407,6 +2411,12 @@ apply_intended_configuration (MsdXrandrManager *manager, const char *intended_fi | |||
| GError *my_error; | |||
| gboolean result; | |||
|
|
|||
| #ifdef HAVE_RDA | |||
| if (rda_session_is_remote()) { | |||
There was a problem hiding this comment.
Respect code style. File doesn't use tabs.
|
Any updates on this or should we close it? Tabs need to go, and conflict needs to be fixed to continue with it |
|
This is actually worth finishing, so as to avoid risk of invalidating someone's local monitor setup during a remote connection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With remote sessions (like X2Go, xRDP, etc.) the xRandR configuration is normally handled by the remote desktop technology in use.
This change adds a return early to MATE's xrandr MSD monitor resolution restoring code path, if the session is remote.
Note: this PR requires a new build dependency on librda [1]
[1] https://github.com/ArcticaProject/librda.git