Merge pull request #74 from matecat/parse-segment-state

Parse segment attributes
matecat · Jun 14, 2023 · 5f0015a · 5f0015a
2 parents d28f1ae + 278490f
commit 5f0015a
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/src/XliffParser/XliffParserV2.php b/src/XliffParser/XliffParserV2.php
@@ -186,6 +186,7 @@ protected function extractTransUnit( $transUnit, &$transUnitIdArrayForUniqueness
                             $segSource = $this->extractContentWithMarksAndExtTags( $dom, $childNode, $extractedSource[ 'raw-content' ], $originalData );
                         } else {
                             $segSource[] = [
+                                    'attr'             => $this->extractTagAttributes( $segment),
                                     'mid'              => count( $segSource ) > 0 ? count( $segSource ) : 0,
                                     'ext-prec-tags'    => '',
                                     'raw-content'      => $extractedSource[ 'raw-content' ],
@@ -212,6 +213,7 @@ protected function extractTransUnit( $transUnit, &$transUnitIdArrayForUniqueness
                             $segTarget = $this->extractContentWithMarksAndExtTags( $dom, $childNode, $extractedTarget[ 'raw-content' ], $originalData );
                         } else {
                             $segTarget[] = [
+                                    'attr'             => $this->extractTagAttributes( $segment),
                                     'mid'              => count( $segTarget ) > 0 ? count( $segTarget ) : 0,
                                     'ext-prec-tags'    => '',
                                     'raw-content'      => $extractedTarget[ 'raw-content' ],

diff --git a/tests/XliffParserV2Test.php b/tests/XliffParserV2Test.php
@@ -445,4 +445,21 @@ public function raise_exception_on_duplicate_ids()
             $this->assertEquals('Invalid trans-unit id, duplicate found.', $exception->getMessage());
         }
     }
+
+    /**
+     * @test
+     */
+    public function can_parse_segment_state_attribute()
+    {
+        $parsed = (new XliffParser())->xliffToArray($this->getTestFile('with-segment-state.xliff'));
+
+        $this->assertEquals('0', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-source' ][ 0 ][ 'attr' ][ 'id' ]);
+        $this->assertEquals('initial', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-source' ][ 0 ][ 'attr' ][ 'state' ]);
+        $this->assertEquals('4', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-source' ][ 1 ][ 'attr' ][ 'id' ]);
+        $this->assertEquals('finale', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-source' ][ 1 ][ 'attr' ][ 'state' ]);
+        $this->assertEquals('0', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-target' ][ 0 ][ 'attr' ][ 'id' ]);
+        $this->assertEquals('initial', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-target' ][ 0 ][ 'attr' ][ 'state' ]);
+        $this->assertEquals('4', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-target' ][ 1 ][ 'attr' ][ 'id' ]);
+        $this->assertEquals('finale', $parsed[ 'files' ][ 1 ][ 'trans-units' ][ 1 ][ 'seg-target' ][ 1 ][ 'attr' ][ 'state' ]);
+    }
 }
diff --git a/tests/files/with-segment-state.xliff b/tests/files/with-segment-state.xliff
@@ -0,0 +1,15 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<xliff xmlns="urn:oasis:names:tc:xliff:document:2.0" version="2.0" srcLang="en-US" trgLang="it-IT" xmlns:its="http://www.w3.org/2005/11/its" its:version="2.0">
+    <file id="kcFDnpQ2PrZx0XfO0_dc5:0-350" memsource:taskId="kcFDnpQ2PrZx0XfO0_dc5" canResegment="no" original="Direct-foundations-part-1-sp.xlf">
+        <unit id="0" memsource:tGroupBegin="0" memsource:tGroupEnd="0">
+            <segment id="0" state="initial">
+                <source>Direct Foundations - Part 1 - SP</source>
+                <target></target>
+            </segment>
+            <segment id="4" state="finale">
+                <source>Ciao</source>
+                <target>Hola</target>
+            </segment>
+        </unit>
+    </file>
+</xliff>