Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job_dir attribute to Response class to record where a job ran #570

Merged
merged 10 commits into from
Mar 29, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Mar 25, 2024

includes tests.

TODO

there are probably a bunch more places where the job_dir attribute should be set when executing a job.
also, should we add the same attribute to the Job class @utf? it would only be populated after the job has run which maybe makes for a worse UX?

@janosh janosh added enhancement New feature or request local Running jobs locally labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (a0dae68) to head (227071e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          21       21           
  Lines        1564     1570    +6     
  Branches      425      426    +1     
=======================================
+ Hits         1555     1561    +6     
  Misses          9        9           
Files Coverage Δ
src/jobflow/core/job.py 100.00% <100.00%> (ø)
src/jobflow/core/store.py 100.00% <100.00%> (ø)
src/jobflow/managers/local.py 100.00% <100.00%> (ø)
src/jobflow/utils/__init__.py 100.00% <ø> (ø)
src/jobflow/utils/uid.py 81.57% <ø> (ø)
src/jobflow/utils/uuid.py 100.00% <ø> (ø)

@utf
Copy link
Member

utf commented Mar 25, 2024

Thanks @janosh. I think for now let's leave it off the Job object as really it is a runner feature.

@janosh janosh enabled auto-merge March 29, 2024 11:28
@janosh janosh merged commit e88c571 into main Mar 29, 2024
9 checks passed
@janosh janosh deleted the response-job-dir-attr branch March 29, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request local Running jobs locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants