Add type hint for @job and fix for run_locally #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mypy deprecates the implicit use of None for default values, add the explicit None type hint for
store
in therun_locally
method.The
@job
decorator is supposed to transform anything into aJob
, I think my change is the minimal effort to take to convince type checkers like mypy or pycharm integrated tools that the result will be aJob
. Consider the following examples:Running mypy over this leads to:
Which is the intended behaviour in my opinion.