Bugfix for Vasprun reading with POTCAR for chemical shift calculations #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly handl the edge case of a chemical shift calculation with an associated POTCAR in the same directory. Also added a test for this and added back internal hash testing for POTCARs.
janosh
added
io
janosh
force-pushed
the
master
branch
2 times, most recently
from
3c23114 to
36e289c
Compare
janosh
force-pushed
the
master
branch
4 times, most recently
from
d725325 to
dca98be
Compare
MichaelWolloch
requested review from
shyuep,
janosh and
mkhorton
as code owners
janosh
force-pushed
the
master
branch
2 times, most recently
from
e3fbc67 to
41e6d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
This work is a result of updating atomate to work with the newest pymatgen and custodian releases and figuring out a hard to spot bug that was present there since May. Please see hackingmaterials/atomate#778 (comment) for details.
Another discussion related to this was taking place in #3068. There the hashing system was (hotly) debated and the initial problem was fixed (afaik). I still think that this PR has a nicer version, which is easy to read and preserves the internal hashes. This is why I re-enabled that unit-test. However, I am fine with commenting that out again or use the new
PMG_POTCAR_CHECKSenvironmental variable to make it conditional?