Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Structure.get_symmetry_dataset convenience method (#4268)" #4273

Closed
wants to merge 1 commit into from

Conversation

shyuep
Copy link
Member

@shyuep shyuep commented Jan 28, 2025

This reverts commit 4375e34.

Summary

Major changes:

  • feature 1: ...
  • fix 1: ...

Todos

If this is work in progress, what else needs to be done?

  • feature 2: ...
  • fix 2:

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@shyuep shyuep requested a review from mkhorton as a code owner January 28, 2025 20:31
@shyuep shyuep closed this Jan 28, 2025
@mkhorton
Copy link
Member

I see this was closed but just curious, was there an issue here?

@shyuep
Copy link
Member Author

shyuep commented Jan 31, 2025

Nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants