Fix default transformation_kwargs in analysis.magnetism.analyze.MagneticStructureEnumerator
#4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
force-pushed
the
fix-4184-mag-struc-enum
branch
from
97c475f to
5627409
Compare
DanielYang59
force-pushed
the
fix-4184-mag-struc-enum
branch
from
5627409 to
1358181
Compare
DanielYang59
force-pushed
the
fix-4184-mag-struc-enum
branch
from
27f7356 to
56b830f
Compare
DanielYang59
commented
Jan 29, 2025
| transformation_kwargs = transformation_kwargs or {} | ||
| transformation_kwargs.update(default_transformation_kwargs) | ||
| transformation_kwargs = {"check_ordered_symmetry": False, "timeout": 5} | transformation_kwargs |
There was a problem hiding this comment.
tag the only functional change for easier review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
transformation_kwargsinanalysis.magnetism.analyze.MagneticStructureEnumerator, to close Default values replace the custom input ones in MagneticStructureEnumerator #4184