Fix timeout in command_line.enumlib_caller.EnumlibAdaptor
#4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
force-pushed
the
fix-4185-enumlib-caller-timeout
branch
from
b980d67 to
6947ffc
Compare
DanielYang59
commented
Jan 31, 2025
| with pytest.raises(TimeoutError, match="Enumeration took too long"): | ||
| adaptor._run_multienum() |
There was a problem hiding this comment.
The original test command is incorrect, a bare _run_multienum doesn't generate the necessary input files, and _gen_input_file is needed (therefore Fortran runtime error: Cannot open file 'struct_enum.in': No such file or directory), so perhaps just use run instead.
After fixing this, the run time on my local Apple M4 machine is around 0.04 s
|
Hi @fraricci sorry for the late response, can you help me test if this patch works? I don't have a "slow enough" enumlib job to test with (the unit test job last only 0.04 s and I'm not sure if it's really validating the behaviour), thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
command_line.enumlib_caller.EnumlibAdaptor, to fix Timeout in MagneticStructureEnumerator (and EnumlibAdaptor) does not work #4185Fortran runtime error: Cannot open file 'struct_enum.in': No such file or directory)