wip

docs/producing-messages/1-producing-messages.md

@@ -15,10 +15,12 @@ This method returns a `ProducerBuilder` instance, which contains a few methods t
 The following lines describes these methods.
 
 If you are going to produce a lot of messages to different topics, please use the `asyncPublish` method on the `Junges\Kafka\Facades\Kafka` class
+
 ```php
 use Junges\Kafka\Facades\Kafka;
 
 Kafka::asyncPublish('broker')->onTopic('topic-name')
 ```
 
-The main difference is that the Async Producer is a singleton and will only flush the producer when the application is shutting down, instead of after each send or batch send. That reduces the overhead when you want to send a lot of messages in your request handlers. 
+The main difference is that the Async Producer is a singleton and will only flush the producer when the application is shutting down, instead of after each send or batch send. 
+This reduces the overhead when you want to send a lot of messages in your request handlers. 

src/Factory.php

@@ -31,11 +31,11 @@ public function publish(string $broker = null): MessageProducer
         );
     }
 
-    /** Creates a new ProducerBuilder instance, setting brokers and topic. The producer will be flushed only when the application terminates, and doing SEND does not mean that the message was flushed! */
+    /** Creates a new ProducerBuilder instance, optionally setting the brokers. The producer will be flushed only when the application terminates, and doing SEND does not mean that the message was flushed! */
     public function asyncPublish(string $broker = null): MessageProducer
     {
         if ($this->shouldFake) {
-            return Kafka::fake()->publish();
+            return Kafka::fake()->publish($broker);
         }
 
         return new ProducerBuilder(

src/Producers/Builder.php

@@ -195,6 +195,7 @@ public function build(): Producer
         if ($this->asyncProducer && $this->producer){
             return $this->producer;
         }
+
         $conf = new Config(
             broker: $this->broker,
             topics: [],
@@ -204,14 +205,16 @@ public function build(): Producer
             callbacks: $this->callbacks,
         );
 
-        $res = app(Producer::class, [
+        $producer = app(Producer::class, [
             'config' => $conf,
             'serializer' => $this->serializer,
             'async' => $this->asyncProducer,
         ]);
+
         if ($this->asyncProducer) {
-            $this->producer = $res;
+            $this->producer = $producer;
         }
-        return $res;
+
+        return $producer;
     }
 }

src/Producers/Producer.php

@@ -40,6 +40,7 @@ public function __construct(
             'conf' => $this->setConf($this->config->getProducerOptions()),
         ]);
         $this->dispatcher = App::make(Dispatcher::class);
+
         if ($this->async) {
             app()->terminating(function () {
                 $this->flush();
@@ -114,7 +115,7 @@ public function produceBatch(MessageBatch $messageBatch): int
             $produced++;
         }
 
-        if (!$this->async) {
+        if (! $this->async) {
             $this->flush();
         }