Add int casting to getLastRestart method #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cache driver is Redis and you retrieve a value from the store, it's automatically string type because of how Redis retrieves these values. Even if key "laravel-kafka:consumer:restart" is stored as an integer on RestartConsumersCommand, when retrieving, Redis will return that as a string.
The problem is the combination of strict_types=1 and type hinting. PHP can't automatically convert that to an integer, so there is a type error exception.
On this PR we cast the result of getLastRestart, so it's always an integer.