Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1131 #1132

Merged
merged 3 commits into from
Jan 18, 2024
Merged

fixes #1131 #1132

merged 3 commits into from
Jan 18, 2024

Conversation

affeldt-aist
Copy link
Member

Motivation for this change
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added this to the 0.6.7 milestone Jan 5, 2024
@affeldt-aist
Copy link
Member Author

ping @CohenCyril ?

@affeldt-aist affeldt-aist modified the milestones: 0.6.7, 0.6.8 Jan 9, 2024
@affeldt-aist
Copy link
Member Author

Since we gain a few lines I will probably merge this one for the next release.

Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, except for the changelog which contains too much wrt this PR

@affeldt-aist
Copy link
Member Author

The failing CI check seems to be an installation problem of finmap, I guess the needed version is not available yet.

@affeldt-aist affeldt-aist merged commit 1c0b3be into math-comp:master Jan 18, 2024
27 of 28 checks passed
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Jan 19, 2024
proux01 pushed a commit that referenced this pull request Jan 20, 2024
@proux01 proux01 added TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. and removed TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants