Merge pull request #3938 from mathesar-foundation/3919_semver

Use a semver library to parse our version strings on the front end

mathesar_ui/package.json

@@ -53,6 +53,7 @@
   "dependencies": {
     "@fortawesome/free-solid-svg-icons": "^6.2.0",
     "@popperjs/core": "^2.11.6",
+    "compare-versions": "^6.1.1",
     "dayjs": "^1.11.5",
     "fast-diff": "^1.2.0",
     "flatpickr": "^4.6.13",

mathesar_ui/src/stores/releases.ts

@@ -1,3 +1,4 @@
+import { compare } from 'compare-versions';
 import { getContext, setContext } from 'svelte';
 
 import {
@@ -31,20 +32,6 @@ function buildRelease(gh: GitHubRelease | undefined): Release | undefined {
   };
 }
 
-function orderableTag(tagName: string): number | undefined {
-  try {
-    const [major, minor, patch] = tagName
-      .split('.')
-      .map((s) => parseInt(s, 10));
-    if (Number.isNaN(major) || Number.isNaN(minor) || Number.isNaN(patch)) {
-      return undefined;
-    }
-    return major * 1000000 + minor * 1000 + patch;
-  } catch (e) {
-    return undefined;
-  }
-}
-
 type UpgradeStatus = 'upgradable' | 'up-to-date';
 
 function getUpgradeStatus(
@@ -54,12 +41,9 @@ function getUpgradeStatus(
   if (current === undefined || latest === undefined) {
     return undefined;
   }
-  const currentNum = orderableTag(current.tagName);
-  const LatestNum = orderableTag(latest.tagName);
-  if (currentNum && LatestNum && LatestNum > currentNum) {
-    return 'upgradable';
-  }
-  return 'up-to-date';
+  return compare(latest.tagName, current.tagName, '>')
+    ? 'upgradable'
+    : 'up-to-date';
 }
 
 export class ReleaseData {