Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and enhance default snippets #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

subecho
Copy link

@subecho subecho commented Jul 17, 2018

This patch improves the reliability and readability of the default
Kotlin snippets. Also added a snippet for creating a function with an
arbitrary number of parameters.

This patch improves the reliability and readability of the default
Kotlin snippets. Also added a snippet for creating a function with an
arbitrary number of parameters.
@nishtahir
Copy link
Collaborator

Thanks for your contribution. I like the changes to the parameter names but I'm not really sure about how the keys are named.

I think it's appropriate to make them a little more verbose, but having them as long as the descriptions seem redundant in my option.

Perhaps we can conform to the same pattern used here? https://github.com/xabikos/vscode-javascript/blob/master/snippets/snippets.json

@subecho
Copy link
Author

subecho commented Nov 5, 2018

Oooh, I like what they did with the Javascript snippets. I'll see if I can update the Kotlin ones to conform to the same. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants