Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-disk support #653

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

DrissiReda
Copy link

@DrissiReda DrissiReda commented Jan 25, 2025

This is to continue upon @smandon's work on #224

Since there have been a lot of changes. I'm waiting for this to be implemented before I can buy and use the turing smart screen.

I made sure to keep compatibility with old configurations.
I can add more themes configuration and also modifications that are needed if this is something the maintainers are interesting in merging.

I need help with designing the UI that can actually display the multiple disks. For now all this is good for is changing the disk whose stats are displayed instead of the default root. Other entries are ignored.

If you have any questions or requests feel free to ask.

@DrissiReda DrissiReda changed the title [WIP] Added multi-disk support Added multi-disk support Feb 11, 2025
@DrissiReda
Copy link
Author

@mathoudebine this should normally solve the backwards compatibility issue that the other similar PR had. Is this something you think can be added?

@mathoudebine
Copy link
Owner

Hi @DrissiReda thank you for opening this PR, this is something that can definitely be added. I just have to think carefully when to merge this PR and the others that are open in a way everything is merged cleanly

@DrissiReda
Copy link
Author

DrissiReda commented Feb 12, 2025 via email

@mathoudebine
Copy link
Owner

Actually there are some things missing from the PR to make it fully working. Since you modified the library/sensors/sensors.py implementation of class Disk(ABC) these changes have to be applied to the other sensor classes that implement this interface.

You made the changes in library/sensors/sensors_python.py but you missed the changes in library/sensors/sensors_librahardwaremonitor.py. I think you can apply the same changes than in sensors_python.py because the same method is used to get disk data (psutil library).

Also, in library/sensors/sensors_stub_random.py and library/sensors/sensors_stub_static.py the 3 functions of the class Disk are missing the new path parameter in argument (even if it will not be used inside the functions)

@DrissiReda
Copy link
Author

Actually there are some things missing from the PR to make it fully working. Since you modified the library/sensors/sensors.py implementation of class Disk(ABC) these changes have to be applied to the other sensor classes that implement this interface.

You made the changes in library/sensors/sensors_python.py but you missed the changes in library/sensors/sensors_librahardwaremonitor.py. I think you can apply the same changes than in sensors_python.py because the same method is used to get disk data (psutil library).

Also, in library/sensors/sensors_stub_random.py and library/sensors/sensors_stub_static.py the 3 functions of the class Disk are missing the new path parameter in argument (even if it will not be used inside the functions)

thanks for the input, I applied the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants