Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read shadowColor from KDecoration2::DecorationShadow #217

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

matinlotfali
Copy link
Owner

@matinlotfali matinlotfali commented May 6, 2024

This is an attempt to resolve #144.

The shadow color can be changed in [ System settings ] -> [ Application Style ] -> [ Window decoration ] -> [ Breeze theme setting ] -> [ Shadows and Outline ] -> [ Shadow Color ]

Sadly, I think it is not possible to have different shadow colors for active and inactive windows.

Do we need them to be different?

@matinlotfali matinlotfali marked this pull request as ready for review May 6, 2024 20:31
@matinlotfali matinlotfali added the Testing This is just for a test. It might not get merged. label May 8, 2024
@jaredmontoya
Copy link

I can't say that nobody wants shadow color to be configurable depending on if the window is active or not, but I believe the absolute majority including me would agree that getting shadow configuration directly from KDE is a good idea.

@noxifoxi
Copy link

Do we need them to be different?

I think (and I think most people do) that having Plasma's shadow parameters is more important than having different shadow colours for inactive/active windows.

(Personally, I don't even know why you'd want a window shadow colour other than black in the first place.)

@matinlotfali
Copy link
Owner Author

@noxifoxi

I think (and I think most people do) that having Plasma's shadow parameters is more important than having different shadow colours for inactive/active windows.

I am reaching the same conclusion

(Personally, I don't even know why you'd want a window shadow colour other than black in the first place.)

It is a historical thing from Plasma 4
https://kde.org/announcements/4/4.6.0/plasma/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing This is just for a test. It might not get merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate to read shadow parameters passed from decoration in KDecoration2::DecorationShadow
3 participants