Enhanced replacement options for generic regexes #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice improvement. Guess we could merge for the next major release. Can't merge that right away, as it might break some of the ports to other languages reusing the yml files. |
sgiehl
force-pushed
the
v4
branch
2 times, most recently
from
71f7ba4
to
147f7a9
Compare
sgiehl
force-pushed
the
v4
branch
4 times, most recently
from
b965528
to
44e7ae3
Compare
sgiehl
force-pushed
the
v4
branch
3 times, most recently
from
65c9c99
to
0f08fdd
Compare
sgiehl
force-pushed
the
v4
branch
2 times, most recently
from
7788806
to
6093675
Compare
sgiehl
force-pushed
the
v4
branch
6 times, most recently
from
4c9f4ff
to
c8c9add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup for #5959, I've tried an idea and would like to suggest this change to have enhanced replacement options for generic regexes.
The idea is that in addition to $1 $2 $3 remplacements, we could also have modifiers like $u1 $l2 $uf3 to replace by an uppercase lowercase or uppercase-first value.
This would allow to keep the current generic non-case-sensitive regexes, while also supporting some user-agents where parts are in a wrong/outrageous case, like the example in the fixture with "Moto G" being provided as "g" in the user-agent.
This is backwards compatible and doesn't slow down the detection.