-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for marketplace provided plugin cover images #21879
Conversation
Failure for I'd be happy to remove the change to the test and add it back after the marketplace change is deployed to production if that's preferred. UPDATE: Discussed in person with MC and will move this to a separate PR that can be merged once the corresponding change is deployed to Marketplace PROD. UPDATE 2: Moved to PR #21915 |
This change can be reviewed, merged and released independently of the marketplace changes as it provides defaults for the category and cover image in the same way how it worked before. |
plugins/Marketplace/tests/resources/v2.0_consumer-access_token-consumer1_paid2_custom1.json
Outdated
Show resolved
Hide resolved
…ies to reflect changes in marketplace
…mensions in template
9b3f990
to
deadd08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Not sure how much sense it makes to merge it before the Marketplace change was applied.
Thanks @sgiehl. I know we don't want dead code that won't be used though I'm confident this will get through at the Marketplace end as well. Also, the change surface here is quite contained, so I think this can be merged. If we need to adjust anything I can follow up on that. |
Description:
The change in this PR allows for use of cover images provided by the plugins marketplace while keeping the existing fallback images for Matomo vs 3rd party plugins.
The PR:
There is also a follow-up draft PR #21915 which should be merged once the corresponding changes to the marketplace have been deployed so that the test there can pass.
ref. DEV-17378
Review