Ensure to only abort the loading request for a popover when closing it #21887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closing a modal / popover currently aborts all running requests. This can lead to problems if there are still some request running that are unrelated to the popover.
It can e.g. be reproduced when the What's new overlay is being loaded.
If you close the modal while the dashboard in background has not yet finished loaded, all dashboard related requests will be terminated and Matomo ends up being in a state where nothing can be performed anymore.
This PR changes the behavior, so that only the initial request to load the content for the popover will be aborted.
If the content being loaded would trigger further ajax requests, those additional requests will no longer be terminated by the popover being closed. This means that popovers need to handle their request-aborting themselves if required.
fixes #21511
Review