Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to only abort the loading request for a popover when closing it #21887

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 6, 2024

Description:

Closing a modal / popover currently aborts all running requests. This can lead to problems if there are still some request running that are unrelated to the popover.

It can e.g. be reproduced when the What's new overlay is being loaded.
If you close the modal while the dashboard in background has not yet finished loaded, all dashboard related requests will be terminated and Matomo ends up being in a state where nothing can be performed anymore.

This PR changes the behavior, so that only the initial request to load the content for the popover will be aborted.
If the content being loaded would trigger further ajax requests, those additional requests will no longer be terminated by the popover being closed. This means that popovers need to handle their request-aborting themselves if required.

fixes #21511

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Feb 6, 2024
@sgiehl sgiehl added this to the 5.1.0 milestone Feb 6, 2024
@sgiehl sgiehl requested a review from a team February 6, 2024 16:05
@sgiehl sgiehl merged commit b2da9d0 into 5.x-dev Feb 8, 2024
22 of 25 checks passed
@sgiehl sgiehl deleted the m21511 branch February 8, 2024 05:36
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Closing a modal might terminate requests from other widgets
2 participants