Added support for CD and CV to Matomo Tag and Variables #201
Conversation
…omo Tag Added support for Custom Variables into the Matomo Variable
| @@ -137,7 +137,84 @@ public function getParameters() | |||
| } | |||
| return $value; | |||
| }; | |||
| }) | |||
| }), | |||
| $this->makeSetting('customDimensions', array(), FieldConfig::TYPE_ARRAY, function (FieldConfig $field) { | |||
There was a problem hiding this comment.
@MichaelHeerklotz Not 100% sure I understand why they are also needed in the Tag and not just in the variable?
There was a problem hiding this comment.
@tsteur As I understand it, triggering Custom Variables or Dimensions in a Tag gives more flexibility, and allows having multiple tags with different Custom Vars/Dims while using the same Matomo Config Variable. I am not a power user yet, but my colleagues requested this feature.
There was a problem hiding this comment.
OK. In case you can find out just also for our understanding: Why is it better to have multiple tags over multiple configurations? Of course when you have multiple variables then it means you still need multiple tags so it be maybe a bit more work using the variables. Just wanting to avoid suddenly having heaps of configurations in the tag that are also in the variable (and more and more coming in their over time) and confusing users because there are two ways to do things. I can kind of see it though for custom dimensions and custom variables as they might be in PAGE/ACTION scope and the variable should maybe be used mostly for VISIT scope.
Wonder if we should explain this in the description that these are maybe mostly meant for custom dimensions in scope action/page?
There was a problem hiding this comment.
Yes, I think so, too. I think it makes sense having them both in the tag and the variable because it makes sense if they are of scope page.
Some explantion would help for sure.
There was a problem hiding this comment.
Should I add some explanations? Is there anything else missing for a merge?
There was a problem hiding this comment.
Nothing else missing to merge but the explanation. This will help users to know when to use what eg MatomoConfig custom dimensions vs Matomo tag custom dimensions.
We'll need to fix the tests then but can do this after merging.
There was a problem hiding this comment.
@MichaelRoosz any chance you could add the explanation as discussed so we can merge?
I think some tests still need to be adjusted, I will update the PR to fix them.
Requires matomo-org/matomo#15125.