Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add twitter conversion tracking #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions Template/Tag/TwitterConversionTag.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
<?php
/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/
namespace Piwik\Plugins\TagManager\Template\Tag;

use Piwik\Settings\FieldConfig;
use Piwik\Plugins\TagManager\Template\Tag\BaseTag;
use Piwik\Validators\NotEmpty;

class TwitterConversionTag extends BaseTag
{
const ID = 'TwitterConversion';

public function getId()
{
return self::ID;
}

public function getName()
{
return parent::getName();
}

public function getDescription()
{
return parent::getDescription();
}

public function getHelp()
{
return parent::getHelp();
}

public function getIcon()
{
return 'plugins/TagManager/images/icons/twitter.svg';
}

public function getParameters()
{
return array(
$this->makeSetting('twitterConversion', '', FieldConfig::TYPE_STRING, function (FieldConfig $field) {
$field->title = 'Pixel ID';
$field->uiControl = FieldConfig::UI_CONTROL_TEXT;
$field->description = '';
$field->validators[] = new NotEmpty();
}),
);
}

public function getCategory()
{
return self::CATEGORY_SOCIAL;
}

}
17 changes: 17 additions & 0 deletions Template/Tag/TwitterConversionTag.web.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
(function () {
return function (parameters, TagManager) {
this.fire = function () {
var id = parameters.get('Pixel ID');
if (id) {
!function (e, t, n, s, u, a) {
e.twq || (s = e.twq = function () {
s.exe ? s.exe.apply(s, arguments) : s.queue.push(arguments);
}, s.version = '1.1', s.queue = [], u = t.createElement(n), u.async = !0, u.src = '//static.ads-twitter.com/uwt.js',
a = t.getElementsByTagName(n)[0], a.parentNode.insertBefore(u, a))
}(window, document, 'script');
twq('init', id);
twq('track', 'PageView');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here in https://business.twitter.com/en/help/campaign-measurement-and-analytics/conversion-tracking-for-websites.html I don't see the conversion type "Pageview"? Only "Site visit", "Purchase", "Download", "Sign up" and "Custom". Also noticed here: https://stackoverflow.com/questions/43937596/are-there-any-different-twitter-pixel-events-than-pageview .

I'm not sure which parameters each type supports. Only seeing value, num_items and order_id... Their docs are rather not so good.

}
};
};
})();
15 changes: 15 additions & 0 deletions images/icons/twitter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.