Adding new tracking type to the Matomo Tag

[tomper00]

Adding new tracking type to the Matomo Tag.

Description:

This adds a new tracking type Search to the Matomo Tag

I would say that the best case to use this feature is when you do not have search parameters in the URL or when you want to add search count to your searches.

You should also set up Variables to handle the inputs (since search is always dynamic).

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[snake14]

Looks pretty good. I think that only a few little changes are needed to get the tests passing. After that, we can try and do some functional testing. Any concerns @AltamashShaikh ?

[AltamashShaikh]

Looks pretty good. I think that only a few little changes are needed to get the tests passing. After that, we can try and do some functional testing. Any concerns @AltamashShaikh ?

@snake14 No concern if its working as expected 👍

[snake14]

@tomper00 Looks like you've just about got the builds fixed. You have a SearchCount instead of searchCount in plugins/TagManager/tests/System/processed/test_webContext__TagManager.getAvailableTagTypesInContext.xml and it looks like searchCategory and searchCount need to be updated with the false default value in plugins/TagManager/tests/System/processed/test___TagManager.exportContainerVersion_site_default_container.xml.

[snake14]

@tomper00 Thank you for getting the tests passing.

I wonder if we should change this branch to Matomo version 5 like your other open PR. @AltamashShaikh ?

[AltamashShaikh]

@snake14 Updated base branch to 5.x-dev

[AltamashShaikh]

@tomper00 Sorry but can you update this migration class name as per your other PR suggestion ?

[AltamashShaikh]

@tomper00 Any updates ?