Skip to content

Commit

Permalink
Unify on one version of the ESRP tasks (dotnet#92451)
Browse files Browse the repository at this point in the history
* Change the macos signing steps to use the same sigining tool version as the Windows signing steps.

* Upgrade code signing task version
  • Loading branch information
jkoritzinsky authored Sep 22, 2023
1 parent 136ac4e commit 9ca60f5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
18 changes: 14 additions & 4 deletions eng/pipelines/common/macos-sign-with-entitlements.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
parameters:
filesToSign: []
timeoutInMinutes: '30'

steps:
- task: UseDotNet@2
displayName: 'Use .NET Core SDK 2.1.808'
displayName: Install .NET 6 SDK for signing.
inputs:
packageType: sdk
version: 2.1.808
packageType: 'sdk'
version: '6.0.x'
installationPath: '$(Agent.TempDirectory)/dotnet'

- ${{ each file in parameters.filesToSign }}:
- script: codesign -s - -f --entitlements ${{ file.entitlementsFile }} ${{ file.path }}/${{ file.name }}
Expand All @@ -28,7 +30,7 @@ steps:
includeRootFolder: true
replaceExistingArchive: true

- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
- task: EsrpCodeSigning@4
displayName: 'ESRP CodeSigning'
inputs:
ConnectedServiceName: 'ESRP CodeSigning'
Expand All @@ -48,6 +50,14 @@ steps:
"toolVersion": "1.0"
}
]
SessionTimeout: ${{ parameters.timeoutInMinutes }}
MaxConcurrency: '50'
MaxRetryAttempts: '5'
PendingAnalysisWaitTimeoutMinutes: '5'
env:
DOTNET_MULTILEVEL_LOOKUP: 0
DOTNET_ROOT: '$(Agent.TempDirectory)/dotnet'
DOTNET_MSBUILD_SDK_RESOLVER_CLI_DIR: '$(Agent.TempDirectory)/dotnet'

- task: ExtractFiles@1
displayName: 'Extract MacOS after signing'
Expand Down
3 changes: 2 additions & 1 deletion eng/pipelines/coreclr/templates/sign-diagnostic-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ steps:
version: '6.0.x'
installationPath: '$(Agent.TempDirectory)/dotnet'

- task: EsrpCodeSigning@1
- task: EsrpCodeSigning@4
displayName: Sign Diagnostic Binaries
inputs:
ConnectedServiceName: 'dotnetesrp-diagnostics-dnceng'
Expand Down Expand Up @@ -48,6 +48,7 @@ steps:
SessionTimeout: ${{ parameters.timeoutInMinutes }}
MaxConcurrency: '50'
MaxRetryAttempts: '5'
PendingAnalysisWaitTimeoutMinutes: '5'
env:
DOTNET_MULTILEVEL_LOOKUP: 0
DOTNET_ROOT: '$(Agent.TempDirectory)/dotnet'
Expand Down

0 comments on commit 9ca60f5

Please sign in to comment.