Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more errors to improve logging #198

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Add more errors to improve logging #198

merged 4 commits into from
Nov 28, 2023

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Nov 14, 2023

Last bit of the work to improve error messages for the commands. Adds errors to:
RunCommand
StatusCommand
VerifyCommand
WidgetCommand

@H-Shay H-Shay requested a review from a team as a code owner November 14, 2023 20:04
reivilibre
reivilibre approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks decent to me, cheers!

@H-Shay H-Shay merged commit 016d55a into main Nov 28, 2023
4 checks passed
@H-Shay H-Shay deleted the shay/more_more_errors branch November 28, 2023 19:07
@H-Shay
Copy link
Contributor Author

H-Shay commented Nov 28, 2023

Merged #198 into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H-Shay @reivilibre