Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove field ITalk.track #239

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove field ITalk.track #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabdd1c
Remove field ITalk.track
reivilibre Dec 16, 2024
866d05d
update snapshot
reivilibre Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Scheduler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,18 +379,6 @@ export class Scheduler {
(task.talk.qa_startTime !== null ? `<p>During the talk, you can ask questions here for the Q&A at the end. ` +
`The questions with the most 👍 votes are most visible to the speaker.</p>` : ''),
);

try {
if (task.talk.track != '' && task.talk.track != undefined) {
const nameEventContent = await this.client.getRoomStateEvent(confAud.roomId, "m.room.name", "");
if (task.talk.track != nameEventContent["name"]) {
nameEventContent["name"] = task.talk.track;
await this.client.sendStateEvent(confAud.roomId, "m.room.name", "", nameEventContent);
}
}
} catch (e) {
LogService.error("Scheduler:talkStart", `Error when considering changing name of track room`, e);
}
} else if (task.type === ScheduledTaskType.TalkQA) {
if (!task.talk.prerecorded) return;
if (confTalk !== undefined) {
Expand Down
7 changes: 0 additions & 7 deletions src/__tests__/backends/penta/__snapshots__/PentabarfParser.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ exports[`parsing pentabarf XML: overview: auditoriums 1`] = `
"startTime": 1675501200000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "Track01",
},
},
},
Expand Down Expand Up @@ -84,7 +83,6 @@ exports[`parsing pentabarf XML: overview: conference 1`] = `
"startTime": 1675501200000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "Track01",
},
},
},
Expand Down Expand Up @@ -146,7 +144,6 @@ exports[`parsing pentabarf XML: overview: talks 1`] = `
"startTime": 1675501200000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "Track01",
},
]
`;
Expand Down Expand Up @@ -182,7 +179,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
"startTime": 1675501200000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "TrackWithQA",
},
{
"auditoriumId": "A.01 (Someroom)",
Expand Down Expand Up @@ -213,7 +209,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
"startTime": 1675502100000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "TrackWithoutQA",
},
{
"auditoriumId": "A.01 (Someroom)",
Expand Down Expand Up @@ -244,7 +239,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
"startTime": 1675503000000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "UnspecifiedTrack",
},
{
"auditoriumId": "AQ.5 (QA Room)",
Expand Down Expand Up @@ -275,7 +269,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
"startTime": 1675503900000,
"subtitle": "",
"title": "Testcon01: Opening Remarks",
"track": "UnspecifiedTrack",
},
]
`;
1 change: 0 additions & 1 deletion src/backends/json/JsonScheduleLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export class JsonScheduleLoader {
qa_startTime: null, // TODO
livestream_endTime: endMoment.valueOf(), // TODO is this right?
speakers: talk.speakers.map(speaker => this.convertSpeaker(speaker)),
track: "", // TODO we have multiple of them!!!

// Must .clone() here because .startOf() mutates the moment(!)
dateTs: startMoment.clone().startOf("day").valueOf(),
Expand Down
1 change: 0 additions & 1 deletion src/backends/penta/PentabarfParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ export class PentabarfParser {
slug: pEvent.slug,
title: pEvent.title,
subtitle: pEvent.subtitle,
track: pEvent.track,
speakers: [],
prerecorded: true,
auditoriumId: auditorium.id,
Expand Down
2 changes: 0 additions & 2 deletions src/backends/pretalx/PretalxParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ interface PretalxTalk {
do_not_record: boolean,
title: string,
subtitle: string,
track: string,
type: string,
language: string,
abstract: string,
Expand Down Expand Up @@ -182,7 +181,6 @@ export async function parseFromJSON(rawJson: string, prefixConfig: IPrefixConfig
startTime: eventDate.getTime(),
subtitle: event.subtitle,
title: event.title,
track: event.track,
prerecorded: false,
speakers: event.persons.map(p => ({
id: p.code,
Expand Down
1 change: 0 additions & 1 deletion src/models/schedule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export interface ITalk {
slug: string;
title: string;
subtitle: string;
track: string;
/**
* MISNOMER: This variable contains ALL people for the talk, NOT JUST speakers.
* TODO rename (at a time when it's a less risky change to do...)
Expand Down
Loading