Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /send_leave to GMSL #387

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Move membership check further to the top, so we can avoid unneeded DB

185a49a
Select commit
Loading
Failed to load commit list.
Open

Move /send_leave to GMSL #387

Move membership check further to the top, so we can avoid unneeded DB
185a49a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 23, 2023 in 0s

59.24% (+0.25%) compared to 2beadf1

View this Pull Request on Codecov

59.24% (+0.25%) compared to 2beadf1

Details

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (2beadf1) 58.99% compared to head (185a49a) 59.24%.

Files Patch % Lines
handleleave.go 71.60% 16 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   58.99%   59.24%   +0.25%     
==========================================
  Files          51       51              
  Lines        7113     7194      +81     
==========================================
+ Hits         4196     4262      +66     
- Misses       2528     2538      +10     
- Partials      389      394       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov