optionally make users wait to join bridged rooms #1645
Conversation
|
a more ideal future here would be one involving knocking, i.e. 60 minutes after you knock, you are invited, or something like that. |
There was a problem hiding this comment.
As you mentioned, inviting people would probably make for better UX.
Is there a way to:
- First time the user knocks, send them a message along the lines of "For user safety, this bridge is configured with a join delay. You will be allowed to join on ${date}."
- After this delay, send an invite.
Maybe?
|
I don't believe knocking is widely implemented yet |
Sorry, I shouldn't have written "knocks" but rather "attempts to join". |
| @@ -1072,8 +1072,13 @@ export class IrcBridge { | |||
| if (userIds) { | |||
| for (const userId of userIds) { | |||
| this.activityTracker.setLastActiveTime(userId); | |||
| this.dataStore.updateLastSeenTimeForUser(userId).catch((ex) => { | |||
| log.warn(`Failed to bump last active time for ${userId} in database`, ex); | |||
| this.dataStore.getFirstSeenTimeForUser(userId).then((when) => { | |||
There was a problem hiding this comment.
I'd make this it's own function inside datastore personally, and have the logic for setting first seen time handled within. We might even be able to wrap the postgres stuff into one statement.
src/bridge/MatrixHandler.ts
Outdated
| user.getId(), | ||
| req, | ||
| true, | ||
| `Please wait ${remaining} seconds`, |
There was a problem hiding this comment.
We probably need to let the user know why they are waiting :). Either a message to their admin room, or a link to a page.
| @@ -66,6 +66,10 @@ export interface BridgeConfig { | |||
| inactiveAfterDays?: number; | |||
| }; | |||
| banLists?: MatrixBanSyncConfig; | |||
| delayBridging?: { | |||
There was a problem hiding this comment.
I think these need more descriptions about what they do. It might even make sense to have this go under the membershipLists configuration where we configure Matrix joins.
We should certainly make it obvious that these are seconds.
| ALTER TABLE last_seen ADD COLUMN first BIGINT; | ||
| ALTER TABLE last_seen RENAME COLUMN ts TO last; | ||
| UPDATE last_seen SET first = last; | ||
| ALTER TABLE last_seen ALTER COLUMN first SET NOT NULL; |
There was a problem hiding this comment.
That might explode for all the existing items that don't have a value set.
There was a problem hiding this comment.
see the line above it; we backfill first from last
couple of
TODOs still; looking for feedback on if i'm going in the right direction