SASL support #643
Merged
SASL support #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
requested changes
Aug 10, 2018
config.sample.yaml
Outdated
| @@ -63,6 +63,9 @@ ircService: | |||
| ssl: true | |||
| # Whether or not IRC server is using a self-signed cert or not providing CA Chain | |||
| sslselfsign: false | |||
| # Should the connection attempt to identify via SASL (if a server or user password is given?) | |||
There was a problem hiding this comment.
Not sure why there is a ?. It reads fine without.
turt2live
approved these changes
Aug 10, 2018
eqyiel
added a commit
to eqyiel/matrix-appservice-irc-nixos
that referenced
this pull request
Sep 11, 2018
eqyiel
added a commit
to eqyiel/matrix-appservice-irc-nixos
that referenced
this pull request
Sep 11, 2018
eqyiel
added a commit
to eqyiel/matrix-appservice-irc-nixos
that referenced
this pull request
Sep 11, 2018
|
@Half-Shot would you happen to know anything about this (kind of related) issue? #689 |
Ralith
pushed a commit
to Ralith/matrix-appservice-irc-nixos
that referenced
this pull request
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix #470