Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix node.js integration by tweaking imports with babel #4373

Closed
wants to merge 1 commit into from

Conversation

Johennes
Copy link
Contributor

Fixes: #4287

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 22, 2024
@richvdh
Copy link
Member

richvdh commented Aug 22, 2024

Hrm, interesting idea. I'm not a huge fan of adding more complexity to the build process though; I'd rather avoid this "magic" if possible.

@Johennes
Copy link
Contributor Author

Johennes commented Aug 22, 2024

Ok, fair enough. Without digging deeper, I'm not entirely sure it wouldn't have caused weird side effects anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matrix-js-sdk no longer works in node
2 participants