Fix the rust crypto import in esm environments. #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
Johennes
reviewed
Oct 8, 2024
dbkr
reviewed
Oct 8, 2024
|
Requested review from crypto too in case they have any input (although I suspect it's mostly a js-level issue) |
|
I've just updated it to use the full path with the |
richvdh
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
This looks good to me.
@saul-jb please could you add a sign-off to your PR, per https://github.com/element-hq/element-web/blob/develop/CONTRIBUTING.md#sign-off
|
(Also: many thanks for doing battle with typescript, babel, jest and nodejs to fix this!) |
MidhunSureshR
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust crypto is broken in ESM environments like nodejs and webpack, this PR simply uses babel to rewrite the import to fix it.
Fixes #4392
See also:
Signed-off-by: Saul Boyd [email protected]