Remove dead release scripts #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now a no-op (there are no `matrix_lib` fields in package.json), so we may as well remove it.
Just as pre-release is a no-op, so is this
Once more: this script is a no-op.
t3chguy
approved these changes
Nov 5, 2024
t3chguy
added a commit
that referenced
this pull request
Nov 12, 2024
Regressed by #4496 Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-release.sh,post-merge-master.shandswitch_package_to_release.[c]jsare all now now no-ops, so we can remove the calls to them, and the scripts themselves.These workflows are referenced from element-web's CI, but only at
develop, so it should be safe to remove the scripts themselves at the same time as updating the workflows.Element-Web does directly refer to
switch_package_to_release.cjs, but element-hq/element-web#28384 removes the reference.