Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use crypto api import for CryptoCallbacks instead of legacy crypto #4526

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Use crypto api import for CryptoCallbacks instead of legacy crypto #4526

merged 1 commit into from
Nov 13, 2024
+3 −3

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Nov 13, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

The legacy crypto ICryptoCallback are already an reexport of the crypto api CryptoCallback.

@florianduros florianduros added the T-Task Tasks for the team like planning label Nov 13, 2024
@florianduros florianduros mentioned this pull request Nov 13, 2024
Open
@florianduros florianduros marked this pull request as ready for review November 13, 2024 10:33
@florianduros florianduros requested a review from a team as a code owner November 13, 2024 10:33
@florianduros florianduros added this pull request to the merge queue Nov 13, 2024
Merged via the queue into develop with commit 52bdb57 Nov 13, 2024
35 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/use-crypto-api-cryptocallback branch November 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy