Enable @typescript-eslint/consistent-type-imports lint rule #4611
+1,187
−1,075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some background on this rule: https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how/ We already have the equivalent of this for exports from https://github.com/matrix-org/eslint-plugin-matrix-org/blob/a1ce5fbb7d425b932c504ae2bb7f985e3c07d9fd/typescript.js#L99 Revert "Enable @typescript-eslint/consistent-type-imports lint rule" This reverts commit 41a02493d0f30d74b5f76ee076b6574c7835e236. .
Revert "Fix resulting violations" This reverts commit 9aea668. Fix violations
t3chguy
reviewed
Jan 10, 2025
| @@ -139,6 +139,8 @@ module.exports = { | |||
| }, | |||
| ], | |||
| "no-extra-boolean-cast": "error", | |||
| // to avoid unnecessary runtime dependencies between files | |||
| "@typescript-eslint/consistent-type-imports": ["error", { fixStyle: "inline-type-imports" }], | |||
There was a problem hiding this comment.
Should we add this to https://github.com/matrix-org/eslint-plugin-matrix-org/blob/a1ce5fbb7d425b932c504ae2bb7f985e3c07d9fd/typescript.js#L99 instead?
There was a problem hiding this comment.
That would make sense to me, assuming agreeable that this is generally a Good Thing.
If so I can make the necessary PRs.
hughns
added a commit
to matrix-org/eslint-plugin-matrix-org
that referenced
this pull request
Jan 14, 2025
Some background on this rule: https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how/ Originally this was just for matrix-js-sdk: matrix-org/matrix-js-sdk#4611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative PR after encountering an unexpected (and unnecessary) circular dependency in some unit tests.
Some background on this rule: https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how/
We already have the equivalent of this for exports from https://github.com/matrix-org/eslint-plugin-matrix-org/blob/a1ce5fbb7d425b932c504ae2bb7f985e3c07d9fd/typescript.js#L99
Checklist
public/exportedsymbols have accurate TSDoc documentation.