Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Appease webpack #10163

Closed
wants to merge 2 commits into from
Closed

Appease webpack #10163

wants to merge 2 commits into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 14, 2023

Signed-off-by: Suguru Hirahara [email protected]

This change stops webpack from issuing warnings related to justify-content: start. See: element-hq/element-web#23595

type: task

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Feb 14, 2023
Signed-off-by: Suguru Hirahara <[email protected]>
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those warnings and why does PostCSS spit them out?
I'm not convinced this is the right fix. I have a hunch this happens because of outdated packages
Using justify-content: start is completely valid in this instance and I would not want to change our code to satisfy this tool's incorrect expectations

@germain-gg germain-gg removed the request for review from t3chguy February 14, 2023 15:56
@luixxiul
Copy link
Contributor Author

2023-02-15 00:14:44.855 [element-js] (53:9) start value has mixed support, consider using flex-start instead
2023-02-15 00:14:44.856 [element-js] ℹ 「wdm」: Compiled with warnings.
2023-02-15 00:15:03.352 [element-js] ℹ 「wdm」: Compiling...
2023-02-15 00:15:07.710 [element-js] ⚠ 「wdm」:    2648 modules
2023-02-15 00:15:07.710 [element-js]
2023-02-15 00:15:07.710 [element-js] WARNING in ../matrix-react-sdk/res/themes/light/css/light.pcss (./node_modules/css-loader/dist/cjs.js??ref--8-1!./node_modules/postcss-loader/src??postcss!../matrix-react-sdk/res/themes/light/css/light.pcss)
2023-02-15 00:15:07.710 [element-js] Module Warning (from ./node_modules/postcss-loader/src/index.js):
2023-02-15 00:15:07.710 [element-js] Warning
2023-02-15 00:15:07.710 [element-js]
2023-02-15 00:15:07.710 [element-js] (53:9) start value has mixed support, consider using flex-start instead
2023-02-15 00:15:07.710 [element-js]
2023-02-15 00:15:07.710 [element-js] WARNING in ../matrix-react-sdk/res/themes/dark/css/dark.pcss (./node_modules/css-loader/dist/cjs.js??ref--8-1!./node_modules/postcss-loader/src??postcss!../matrix-react-sdk/res/themes/dark/css/dark.pcss)
2023-02-15 00:15:07.710 [element-js] Module Warning (from ./node_modules/postcss-loader/src/index.js):
2023-02-15 00:15:07.710 [element-js] Warning
2023-02-15 00:15:07.710 [element-js]
2023-02-15 00:15:07.710 [element-js] (53:9) start value has mixed support, consider using flex-start instead
2023-02-15 00:15:07.711 [element-js] ℹ 「wdm」: Compiled with warnings.

Essentially the same PR as #9500.

As I myself am not annoyed with these warnings, it's ok for me to close this.

What do you think?

@germain-gg
Copy link
Contributor

I understand what you're getting at, I'm just not sure this is how we should approach it.
We're changing our codebase to satisfy a tool that has a wrong assumption, I'll bring that up with a few other folks as it does not seem we have consensus on the matter

@luixxiul luixxiul closed this Feb 17, 2023
@luixxiul
Copy link
Contributor Author

Might be reopened after element-hq/element-web#23597 is resolved.

@luixxiul luixxiul deleted the appease-postcss-loader branch February 17, 2023 07:37
@luixxiul luixxiul restored the appease-postcss-loader branch February 17, 2023 07:37
@luixxiul luixxiul deleted the appease-postcss-loader branch April 14, 2023 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants