Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fuzzy search #10282

Closed
wants to merge 4 commits into from
Closed

Fuzzy search #10282

wants to merge 4 commits into from

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Mar 3, 2023 •
edited by github-actions bot
Loading

ℹ️ ignore this PR for now

ToDo: Add a setting for fuzzy search (disabled by default).

fuzzy

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@weeman1337 weeman1337 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 3, 2023
@leeoniya
Copy link

leeoniya commented Mar 3, 2023

fzf is okay...but there are better options ;)

https://github.com/leeoniya/uFuzzy#a-biased-appraisal-of-similar-work

@weeman1337
Copy link
Contributor Author

fzf is okay...but there are better options ;)

https://github.com/leeoniya/uFuzzy#a-biased-appraisal-of-similar-work

There is always a better option ;)

@weeman1337
Copy link
Contributor Author

Other work on search: #8275
Just to keep that in mind and to not break it.

@daniellekirkwood daniellekirkwood self-assigned this Mar 13, 2023
@daniellekirkwood daniellekirkwood removed their assignment Apr 4, 2023
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
52d46c5 
… weeman1337/fuzzy-search

# Conflicts:
#	src/components/views/dialogs/spotlight/SpotlightDialog.tsx
@weeman1337
Copy link
Contributor Author

weeman1337 commented Aug 8, 2023 •
edited
Loading

There are (in my opinion) still some things to do here:

  • Refactoring of the spotlight search:
    • Pull out search logic from the UI component
    • Introduce some interfaces
    • It should be possible to switch between algorithms (such as the current one and fzf). The refactoring should be done in a separate PR before.
  • Put the new search behind a setting or labs flag

There is a chance that I can find some time end of August to work on this.

@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2023 •
edited
Loading

@weeman1337 oh definitely, and currently it re-regresses element-hq/element-web#24422 - just trying to get a Netlify build on a more recent develop

@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2023 •
edited
Loading

Think it'd be good to highlight more than just the name also, maybe even go as far as to replace the 2nd-ary text with the most-matching field if it is a !visible one (e.g. topic)

image

This is super good already though

@weeman1337 weeman1337 closed this Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weeman1337 @leeoniya @t3chguy @daniellekirkwood