Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add space for vertical stroke on message edit composer on Rich Text Editor mode #10749

Closed
wants to merge 2 commits into from
Closed

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 30, 2023

Fixes element-hq/element-web#25237

This PR intends to add space for vertical stroke on message edit composer of Rich Text Editor. It also suggests to add E2E tests for edit composers on both CIDER and RTE, with two new Percy screenshots: EditComposer on EventTile - CIDER and EditComposer on EventTile - Rich Text Editor.

Here are cropped screenshots of message edit composer on RTE mode:

Before After
Screenshot from 2023-05-01 00-01-04 Screenshot from 2023-05-01 00-03-39

Please note that this PR intentionally suggests to create two EditComposer categories for CIDER and RTE, so that they will be added with other tests for each mode.

type: defect

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The green left stroke on the event tile being edited is hidden with the Rich Text message editor on IRC layout
1 participant