This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make widgets take up the full height of the PiP again #10886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a visual regression introduced in 73007d6: AppTiles with the class mx_AppTile_mini don't get an mx_AppsDrawer as their parent, so the --AppTile_mini-height variable needs a broader scope.
robintown
added
the
T-Defect
Just a reminder, it's helpful to link to the PR that introduces a regression (#10775 in this case) so that Github records a link in both directions. That way, if you're looking at a given PR, you have some chance of tracking down the followups that have happened. |
richvdh
approved these changes
May 15, 2023
|
Given that #10775 has not yet landed in a release, is it correct that this be recorded in the changelog as a bugfix? @t3chguy / @andybalaam any thoughts? |
|
@richvdh shouldn't be in the changelog if defect didn't touch a release |
|
Thanks, will make it a T-Task and merge |
richvdh
added
T-Task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a visual regression introduced in 73007d6:
AppTileswith the classmx_AppTile_minidon't get anmx_AppsDraweras their parent, so the--AppTile_mini-heightvariable needs a broader scope.This change is marked as an internal change (Task), so will not be included in the changelog.