Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use Intl to localise dates and times #11422

Merged
merged 26 commits into from
Aug 21, 2023
Merged

Use Intl to localise dates and times #11422

merged 26 commits into from
Aug 21, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 17, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25608

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 17, 2023
@t3chguy t3chguy mentioned this pull request Aug 17, 2023
Closed
@t3chguy t3chguy self-assigned this Aug 17, 2023
@t3chguy t3chguy mentioned this pull request Aug 17, 2023
Closed
@t3chguy t3chguy changed the title Get country names from the browser instead of manual i18n Get localisations from the browser instead of manual i18n Aug 18, 2023
@t3chguy t3chguy marked this pull request as ready for review August 18, 2023 09:42
@t3chguy t3chguy requested a review from a team as a code owner August 18, 2023 09:42
richvdh
richvdh suggested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I'm getting bored here. There's a lot changing, please break into smaller PRs.

src/DateUtils.ts Show resolved Hide resolved
src/DateUtils.ts Show resolved Hide resolved
src/DateUtils.ts Outdated Show resolved Hide resolved
src/DateUtils.ts Outdated Show resolved Hide resolved
src/DateUtils.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member Author

t3chguy commented Aug 18, 2023

Thanks @richvdh - split out #11427 & #11428 - will address your comments on this PR next

@t3chguy t3chguy requested a review from richvdh August 18, 2023 13:39
richvdh
richvdh suggested changes Aug 21, 2023
View reviewed changes
src/DateUtils.ts Outdated Show resolved Hide resolved
src/DateUtils.ts Outdated Show resolved Hide resolved
src/DateUtils.ts Outdated Show resolved Hide resolved
src/DateUtils.ts Show resolved Hide resolved
test/utils/DateUtils-test.ts Outdated Show resolved Hide resolved
src/languageHandler.tsx Outdated Show resolved Hide resolved
test/components/views/rooms/__snapshots__/PinnedEventTile-test.tsx.snap Outdated Show resolved Hide resolved
src/components/views/dialogs/ForwardDialog.tsx Show resolved Hide resolved
test/components/views/dialogs/__snapshots__/MessageEditHistoryDialog-test.tsx.snap Outdated Show resolved Hide resolved
@t3chguy @richvdh
Apply suggestions from code review
e28d6a9 
Co-authored-by: Richard van der Hoff <[email protected]>
@t3chguy @richvdh
Update src/DateUtils.ts
ceba3db 
Co-authored-by: Richard van der Hoff <[email protected]>
@t3chguy t3chguy requested a review from richvdh August 21, 2023 16:31
richvdh
richvdh approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/DateUtils.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy enabled auto-merge August 21, 2023 19:06
@t3chguy t3chguy added this pull request to the merge queue Aug 21, 2023
Merged via the queue into develop with commit 3c52ba0 Aug 21, 2023
19 checks passed
@t3chguy t3chguy deleted the t3chguy/localazy-use-intl branch August 21, 2023 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @richvdh