Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Sticky headers repositioning without layout trashing #6110

Merged
merged 4 commits into from
May 28, 2021

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented May 27, 2021

Fixes matrix-org/element-web-rageshakes#5371

Issue introduced as part of #6095

Reintroducing the sizing set by JavaScript for the sticky header due to a browser incompatibiltiy between Firefox and Chrome (Although Ryan pointed out that Firefox Nightly is behaving properly)

This is done in a manner that does not rely on clientWidth to avoid layout trashing

@germain-gg germain-gg requested a review from a team May 27, 2021 11:48
@germain-gg germain-gg changed the title Track left panel width using ResizeObserver Sticky headers repositioning without layout trashing May 28, 2021
@jryans
Copy link
Collaborator

jryans commented May 28, 2021

Reintroducing the sizing set by JavaScript for the sticky header due to a browser incompatibiltiy between Firefox and Chrome (Although Ryan pointed out that Firefox Nightly is behaving properly)

What is the compat issue in more detail? A mismatch in flexbox width handling, or something else...?

@germain-gg
Copy link
Contributor Author

Reintroducing the sizing set by JavaScript for the sticky header due to a browser incompatibiltiy between Firefox and Chrome (Although Ryan pointed out that Firefox Nightly is behaving properly)

What is the compat issue in more detail? A mismatch in flexbox width handling, or something else...?

I haven't been able to find more information. I scanned through bugzilla and https://wpt.fyi/ but couldn't find the root cause of this issue.
I'm hopeful that a lot of that will be able to go away when we tackle #6054

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😄

@germain-gg germain-gg merged commit 71b217e into develop May 28, 2021
@germain-gg germain-gg deleted the gsouquet/sticky-header-sizing branch May 28, 2021 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants