Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove unused LeftPanel dimension tracking #7845

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Feb 18, 2022

I noticed this was unused while looking through resize observer paths.


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr7845--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

This tracking was not being cleaned up (though unmounts are surely rare here),
and was also never listened to.
@jryans jryans added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 18, 2022
@jryans jryans requested a review from a team as a code owner February 18, 2022 14:22
@t3chguy
Copy link
Member

t3chguy commented Feb 18, 2022

I wonder if hooking it back up will fix the Safari issue

27ee7c5#diff-bb5eeeda9a8d5f7b2a4cbcce491cfbf482b2c704207b28a167d31992851e7c1aR95

element-hq/element-web#17283

/me tests

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, blow it to smithereens

@jryans jryans merged commit acd051d into develop Feb 18, 2022
@jryans jryans deleted the jryans/rm-leftpanel-dims branch February 18, 2022 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants