fix(ui): Do not filter out own receipts in load_read_receipts_for_event #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_receipts This is consistent with load_user_receipt and avoids suprises in test results that rely on both methods. It also avoids to need to rely on a precise event ID. Signed-off-by: Kévin Commaille <[email protected]>
They are already filtered out where needed in maybe_update_read_receipt. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
==========================================
- Coverage 85.73% 85.73% -0.01%
==========================================
Files 291 291
Lines 33288 33287 -1
==========================================
- Hits 28538 28537 -1
Misses 4750 4750 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Feb 3, 2025
| .handle_back_paginated_event( | ||
| timeline | ||
| .factory | ||
| .event(carol_event_content) |
There was a problem hiding this comment.
can call .text_msg("I am Carol!") instead of creating the RoomMessageEventContent manually.
| .handle_back_paginated_event( | ||
| timeline | ||
| .factory | ||
| .event(bob_event_content) |
| .handle_back_paginated_event( | ||
| timeline | ||
| .factory | ||
| .event(alice_event_content) |
Signed-off-by: Kévin Commaille <[email protected]>
bnjbvr
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4517.
It turns out that the bugs found in that test were due to 2 causes:
TestRoomDataProviderdidn't useinitial_user_receiptsbut returned hardcoded values.TimelineStateTransaction::load_read_receipts_for_event, although we need to process all read receipts viaReadReceipts::maybe_update_read_receiptbecause it knows how to filter out our own read receipts were needed.