MSC2867: Marking rooms as unread #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
kind:feature
Bubu
force-pushed
the
unread_rooms
branch
2 times, most recently
from
c401fc2
to
8495e0b
Compare
uhoreg
reviewed
Nov 19, 2020
Signed-off-by: Marcus Hoffmann <[email protected]>
SpiritCroc
reviewed
Nov 22, 2020
Kirchmaus
pushed a commit
to SchildiChat/SchildiChat-android
that referenced
this pull request
Dec 5, 2020
Using com.famedly.marked_unnread, as per [MSC2867](matrix-org/matrix-spec-proposals#2867) TODO: - Currently, when upgrading from an older version, already existing unread flags are ignored until cache is cleared manually Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
Kirchmaus
pushed a commit
to SchildiChat/SchildiChat-android
that referenced
this pull request
Dec 5, 2020
Using com.famedly.marked_unnread, as per MSC2867 (matrix-org/matrix-spec-proposals#2867) TODO: - Currently, when upgrading from an older version, already existing unread flags are ignored until cache is cleared manually Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
Kirchmaus
pushed a commit
to SchildiChat/SchildiChat-android
that referenced
this pull request
Dec 9, 2020
Using com.famedly.marked_unnread, as per MSC2867 (matrix-org/matrix-spec-proposals#2867) TODO: - Currently, when upgrading from an older version, already existing unread flags are ignored until cache is cleared manually Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
|
This has been implemented in the Beeper app |
turt2live
reviewed
Aug 5, 2021
|
Next SchildiChat Web/Desktop release will have this too. |
4 tasks
9 tasks
4 tasks
3 tasks
anoadragon453
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Conversely, this feature has been asked for for years and while simple, I think it covers the majority of use cases. I vote for getting this in to people's hands. In the future we can always migrate to something more powerful if that ends up being warranted.
aka. let's avoid letting perfect be the enemy of good and iterate instead of blocking further.
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
richvdh
reviewed
Jun 18, 2024
grammar improvement Co-authored-by: Richard van der Hoff <[email protected]>
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
added
spec-pr-missing
turt2live
added a commit
that referenced
this pull request
Jun 24, 2024
* marking rooms as unread Signed-off-by: Marcus Hoffmann <[email protected]> * Add alternative suggestion by @turt2live Co-authored-by: Travis Ralston <[email protected]> * mention that this msc lacks thread support * typo fix * clarify type of notification we are referring to * fix some small typos * Update proposals/2867-rooms_marked_unread.md grammar improvement Co-authored-by: Richard van der Hoff <[email protected]> --------- Signed-off-by: Marcus Hoffmann <[email protected]> Co-authored-by: Travis Ralston <[email protected]> Co-authored-by: Andrew Morgan <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
Johennes
added a commit
to Johennes/matrix-spec
that referenced
this pull request
Jul 1, 2024
Relates to: matrix-org/matrix-spec-proposals#2867 Signed-off-by: Johannes Marbach <[email protected]>
3 tasks
|
Spec PR: matrix-org/matrix-spec#1895 |
tulir
added
spec-pr-in-review
clokep
added
merged
|
Merged 🎉 |
41 tasks
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
FCP tickyboxes