Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to push rule condition kinds. #1841

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

clokep
Copy link
Member

@clokep clokep commented Jun 5, 2024

@clokep clokep marked this pull request as ready for review June 5, 2024 00:47
@clokep clokep requested a review from a team as a code owner June 5, 2024 00:47
@clokep
Copy link
Member Author

clokep commented Jun 5, 2024

I'm not sure why it thinks the link is broken? It also doesn't seem to have generated a preview. 😢

@zecakeh
Copy link
Contributor

zecakeh commented Jun 6, 2024

The IDs of the page are deduplicated in the browser by manipulating the DOM with JavaScript, and adding a number to the ID. If the test doesn't do the same thing, it will probably not know the real IDs for the links.

@zecakeh
Copy link
Contributor

zecakeh commented Jun 6, 2024

It looks like the easiest solution here is to use the IgnoreURLs option of htmltest.

A better solution would probably be to do the deduplication (and generating the ToC) at rendering time with Hugo, somehow.

@zecakeh
Copy link
Contributor

zecakeh commented Jun 8, 2024

#1851 should fix the issue with the CI.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you merge in main to check that it fixes CI?

@clokep clokep enabled auto-merge (squash) June 11, 2024 21:42
@clokep clokep merged commit da3e884 into matrix-org:main Jun 11, 2024
12 checks passed
@clokep clokep deleted the clokep/conditions-link branch June 11, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants