-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to push rule condition kinds. #1841
Conversation
Signed-off-by: Patrick Cloke <[email protected]>
I'm not sure why it thinks the link is broken? It also doesn't seem to have generated a preview. 😢 |
The IDs of the page are deduplicated in the browser by manipulating the DOM with JavaScript, and adding a number to the ID. If the test doesn't do the same thing, it will probably not know the real IDs for the links. |
It looks like the easiest solution here is to use the A better solution would probably be to do the deduplication (and generating the ToC) at rendering time with Hugo, somehow. |
#1851 should fix the issue with the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you merge in main
to check that it fixes CI?
As reported by https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$6qi3oaPnzhcBphCN57WC3PDsP9Y5juch2QJGp2ceMgQ?via=matrix.org&via=envs.net&via=element.io.
Signed-off-by: Patrick Cloke [email protected]