Remove reply fallbacks #1994
Open
Remove reply fallbacks #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per MSC2781. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
commented
Nov 14, 2024
| @@ -0,0 +1 @@ | |||
| Remove reply fallbacks, as per [MSC2781](https://github.com/matrix-org/matrix-spec-proposals/issues/2781). | |||
There was a problem hiding this comment.
It should probably be a *.removal changelog, but given that the generated heading says "Endpoints Removed", it is not quite right.
Signed-off-by: Kévin Commaille <[email protected]>
clokep
reviewed
Nov 14, 2024
Comment on lines
103
to
104
| In previous versions of the specification, [rich replies](#rich-replies) could | ||
| use a special tag, `mx-reply`, this is no longer the case. |
There was a problem hiding this comment.
Doesn't this need to mention that it should always be stripped still?
There was a problem hiding this comment.
Yes, I added a sentence here.
Comment on lines
+26
to
+27
| replies, this is no longer the case. Clients might still want to remove this | ||
| fallback before rendering the event. |
There was a problem hiding this comment.
I think they must remove it, no?
There was a problem hiding this comment.
There is not must in the MSC. There is:
Clients […] should consider treating
<mx-reply>parts as they treat other invalid html tags.
And
[…] clients may need to strip out such fallbacks.
Signed-off-by: Kévin Commaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per MSC2781.
Pull Request Checklist
Preview: https://pr1994--matrix-spec-previews.netlify.app