-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier config #123
base: master
Are you sure you want to change the base?
Add prettier config #123
Conversation
I did two commits one with the changes and one with just |
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I'm able to get a slightly smaller diff by running Prettier on the original source:
git checkout master -- src/ test/ && yarn prettier:format && git add src/ test/
You can use it if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize Element Call has a VSCode settings file too, but I'm not a fan of putting IDE config files in version control, as they can clash with personal development preferences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(To be clear, the request is to remove this file 🙂)
It should also be made clear that the code coverage test fails simply because this PR touches most source/test files, and the code coverage %age of the whole codebase is lower than the minimum per-PR coverage requirement...meaning 1) this is a false-positive and 2) code coverage should eventually be improved in general so this won't be an issue anymore! |
This adds a prettier config.
Before this format on save changed a lot of lines.